fix(ui5-breadcrumbs): current link aria-current #9668
Conversation
packages/main/src/Breadcrumbs.ts
Outdated
| @@ -628,9 +628,10 @@ class Breadcrumbs extends UI5Element { | |||
| return this._overflowItemsData.length === 0; | |||
| } | |||
|
|
|||
| get linkAccessibilityAttributes(): Pick<AccessibilityAttributes, "hasPopup"> { | |||
| get linkAccessibilityAttributes() { | |||
There was a problem hiding this comment.
get linkAccessibilityAttributes(): Pick<AccessibilityAttributes, "hasPopup" | "current">
instead of removing the type
PetyaMarkovaBogdanova
force-pushed
the
breadcumbs-item-aria-current
branch
2 times, most recently
from
304576e
to
10858fb
Compare
PetyaMarkovaBogdanova
requested review from
nnaydenow,
NHristov-sap and
unazko
There was a problem hiding this comment.
The aria-current isn't listed in the inherited or supported properties for the link role.
Nevertheless it should be globally supported regardless of the role attribute and also it is not prohibited according to the ARIA 1.2 standard.
According to the design the current page appears visually as a text (it lacks navigation).
Not sure if such an element should still have a link role. Also it seems that the ACC spec isn't updated although there is a listed aria-current="true" attribute.
Is this topic presented in front of the accessibility expert group?
PetyaMarkovaBogdanova
force-pushed
the
breadcumbs-item-aria-current
branch
from
10858fb
to
0ce6b28
Compare
Fixes: #9648